On Mon, 2009-07-06 at 22:09 -0700, Garrett Cooper wrote:
> In order to put libcontrollers.a in an appropriate location, s.t. the
> cpuset, etc tests can properly find it, we need to adjust the Makefile
> to establish feature parity with the current backend supported in the
> cpuset Makefiles.
>
> This patch is needed to properly address the cross-compilation issues
> just posted on the list.
>
> This requires PATCH 2/4 and PATCH 3/4 in order to function.
>
> Signed-off-by: Garrett Cooper <[email protected]>
Great. A Few comments from me:
1. I am little confused over which patches precedes whom. And i am
not seeing PATCH 2/4 and PATCH 3/4 in my mailbox,
2. Can you please send the other patches which has dependencies on
PATCH 2/4 and PATCH 3/4, only after the actual series from PATCH
1 to PATCH 4 has been reviewed by Mike, others, and myself (or
Mike) has checked them in (1 -> 4)
You are already doing a great work, still, i would just like to point
you the following. Give me some robust documentation (i know you have
already initiated that in your patch). I would love to see the
following:
1. A short description on why the present system is having
problems,
2. How the present system (after your fixes are checked in) helps
solve them (cross-compilations, easy mainatinence, autoconf,
etc),
3. Guide to users on how to use the present system,
Once that is done, i would encourage you to come up with some article,
or, whitepaper on a topic say:
--- "Towards a better LTP Build System" ---
I would help you to get it published in lwn.net(you yourself can even do
that if you have more clout with them). We can even send it to other
forums. This is very important from our projects perspective. If the
changes that we are about to make is really helpful to kernel
developers, the article should encourage them to use LTP. And hence we
will increase LTP contribution significantly in the long run. The
projectś visibility will improve drastically. Hope you understand my
point.
Regards--
Subrata
>
> Index: testcases/kernel/controllers/libcontrollers/Makefile
> ===================================================================
> RCS file:
> /cvsroot/ltp/ltp/testcases/kernel/controllers/libcontrollers/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- testcases/kernel/controllers/libcontrollers/Makefile 28 Feb 2008
> 14:50:59 -0000 1.1
> +++ testcases/kernel/controllers/libcontrollers/Makefile 7 Jul 2009
> 05:04:11 -0000
> @@ -1,15 +1,38 @@
> -TARGET=libcontrollers.a
> -SRCS=$(wildcard *.c)
> -OBJS=$(patsubst %.c,%.o,$(SRCS))
> +#
> +# testcases/kernel/controllers library Makefile.
> +#
> +# Copyright (C) 2009, Cisco Systems Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +#
> +# Garrett Cooper, July 2009
> +#
> +# Copyright (c) 2009 by Cisco Systems, Inc.
> +# All rights reserved
> +#
> +
> +srcdir ?= ../../../..
> +
> +include $(srcdir)/include/master_include.mk
> +
> +INSTALL_DIR := $(libdir)
>
> -all : $(TARGET)
> +LIB := lib$(LIBSUFFIX).a
>
> -$(TARGET): $(OBJS)
> - $(AR) -cr $@ $^
> -
> -clean:
> - rm -f $(TARGET) $(OBJS)
> -
> -install:
> +MAKE_TARGETS := $(LIB)
>
> +$(LIB): $(OBJS)
>
> +$(eval $(generic_leaf_target))
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/blackberry
> _______________________________________________
> Ltp-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
