On Monday 06 July 2009 20:22:19 Garrett Cooper wrote: > 1. Better modularize and separate out the top-level Makefile such that > automake logic and top-level targets are better partitioned out, and > thus the overall logic and flow is more intuitive. > 2. Move help output to README.mk-user. > 3. Make $(.DEFAULT_GOAL) vary depending on whether or not the system > has been configured, such that typing in make will no longer run all > and result in Make errors, but instead will punt back help, thus > making LTP more newbie friendly and reducing support requests because > people don't RTFM ;)... > 4. Begin deprecation of the uclinux* rules, which can be communicated > using the UCLINUX=[0|1] make env var (like they should have been in > the beginning). > 5. Add appropriate GPLv2 copyright headers wherever needed. > > Notes: > 1. Requires [PATCH 2/4]. > 2. Is an evolution of the commentary w.r.t. the config.mk not required > for clean patch submitted on Saturday.
you have duplicated copyright notices here too please drop the sleep in the uclinux warning you seem to export the variables twice there is a $(basename ...) make function so you dont need to use `basename` you check SKIP_IDCHECK in some targets ... this is a make var, so using ifeq(...) instead is better -- avoids @ and nesting and set -e and other crap the if checking in the clean target seems unnecessary please use "$" to indicate prompts in documentation, not "$$" for pre/post install hooks, why not declare a common name and everyone use that rather than forcing people to declare it. i.e. declare the target "post- install-hook" as a .PHONY and always call/depend/etc... on it. some of your for loops arent using set -e or checking the install exit status why cant testcases/kernel/Makefile leverage these .mk files ? the whole point was to get away from these custom written jobbies ... you're mixing CFLAGS and CPPFLAGS. -I/-D is for CPPFLAGS. what's this business of every Makefile having to declare MAKE_TARGETS ? this should be a common default. rather than force everyone to hardcode the default ltp -I inc and -L lib paths, these should be added to the global defaults doing a for loop on a `rm` command is silly. call `rm` once. debugging/optimization/warning/stripping flags shouldnt be added in any Makefile that is being converted to these common .mk files. same for any DEBUG_XXX flags. i dont see the point in declaring empty rules like "install: ;". if they're declared .PHONY, there is no need to add explicit rules to sub Makefiles. clean targets should always delete common things like "*.o". forcing people to have to manually declare these is a waste. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
