On Friday 10 July 2009 06:46:35 Subrata Modak wrote: > On Thu, 2009-07-09 at 03:03 -0400, Mike Frysinger wrote: > > the perceived problem: many many tests duplicate errno display and > > they do so inconsistently. many times the display is crappy and a lot > > less helpful than it could & should be. a test should merely have to say > > "include the errno in the test output" so it can focus on its own details. > > much like the multitude of C library functions out there like perror() or > > printf's %m. > > > > the proposed fix: extend the first argument to (1) take a define for > > the test result and (2) also accept optional bit fields to further > > manipulate the output. the advantage here is we dont have to add a whole > > lot of helper functions to complement the existing ones. i.e. a new > > tst_resmp() that would behave like tst_resm() but also append the errno > > output. > > I like this idea. Very few comments: > > 1. The new patch does not show the implementation of tst_resmp(),
my point was that things like tst_resmp() are not the way to go but instead we should use the first argument as an optional bit field. which is what my patch implements. > 2. If there are changes on this regard, the corresponding > information should be updated in ltp/doc/man3/tst_res.3, thanks, i wasnt aware of this -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
