On Sunday 12 July 2009 01:49:52 Garrett Cooper wrote: > -AC_CONFIG_FILES([config.mk m4/Makefile]) > +AC_CONFIG_FILES([ include/mk/config.mk lib/ltp.pc ltp-devel.spec > m4/Makefile \ +README.ltp-devel ])
if you're going to start splitting lines, might as well do all of them and
keep them sorted
AC_CONFIG_FILES([ \
file1 \
file2 \
file3 \
])
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ ltp-devel.spec.in 12 Jul 2009 05:46:28 -0000
each of the .in files should have a target in the related Makefile so that it
gets updated if the source is modified
ltp-devel.spec: $(srcdir)/ltp-devel.spec.in
./config.status $@
> +++ include/mk/config.mk.in 12 Jul 2009 05:46:28 -0000
> +AIO_LIBS = @AIO_LIBS@
> +CRYPTO_LIB = @CRYPTO_LIB@
> +SELINUX_LIBS = @SELINUX_LIBS@
there should be a note here about standardizing the naming. it should be
"FOO_LIBS", not "_LIB".
> +# Avoid overwriting definitions in leaf callers.
> +CPPFLAGS ?= @CPPFLAGS@ -I$(includedir)
> +CFLAGS ?= @CFLAGS@
> +LDLIBS ?= @LIBS@
> +LDFLAGS ?= @LDFLAGS@ -L$(libdir)
this looks like it'll cause problems if you set these in your environment
export CPPFLAGS='' CFLAGS='-pipe' LDFLAGS=''
make
i would use $(origin ...) to determine whether the variables are coming from
the leaf Makefile
also, please add '-pipe' to default CFLAGS
> +DEBUG_CFLAGS ?= -g
> +DEBUG_CXXFLAGS ?= $(DEBUG_CFLAGS)
> +
> +CFLAGS += $(DEBUG_CFLAGS)
> +CXXFLAGS += $(DEBUG_CXXFLAGS)
> +
> +# There have been several bugs in the past related to -O2+ when
> +# -fno-strict-aliasing is not specified.
> +OPT_CFLAGS ?= -O2 -fno-strict-aliasing
> +OPT_CXXFLAGS ?= $(OPT_CFLAGS)
in general, i recall only like 1 bug that was a gcc issue. all the others
were broken source code. i dont think we should live with code that violates
aliasing rules.
> +#export AR CC CFLAGS CPPFLAGS LDLIBS LDFLAGS RANLIB
forgot to delete ?
> --- m4/GNUmakefile 18 Jan 2009 22:22:40 -0000 1.1
> +++ m4/GNUmakefile 12 Jul 2009 05:46:28 -0000
i think we only need a top level GNUmakefile. all the other subdirs can stay
Makefile.
> +LFLAGS += -l -w
> +CFLAGS += -w
punt these
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
