On Tue, Jul 21, 2009 at 6:01 AM, Michal Simek<[email protected]> wrote: > Garrett Cooper wrote: >> On Sun, Jul 19, 2009 at 10:25 PM, Michal >> Simek<[email protected]> wrote: >>>> >>>> +LIBOBJS := $$(addprefix >>>> $$(builddir)/,$$(patsubst %.c,%.o,$$(LIBSRCS))) >>>> >>>> >>> long line. >>> >> >> I try my best to do two things with makefile code: >> 1. align Makefile code with single tab, then spaces. >> 2. compress as many statements as possible to reduce the number of >> required evaluation steps, because that can result in interesting >> behavior from make with define blocks... >> >> I will try and compress the space further (that line was tab >> separated) in a style cleanup commit after this is all said and >> committed, if I don't get to it sooner. It's just easier to add and >> delete tabs for now :). >> > make no sense to send a patch with coding style violation and then send > next patch > which fixed that bad coding style. It is better to do it properly in > first time. > We have to clean whole LTP source code not pollute it.
I am cleaning up a lot more `style-guide violations' than I am causing in LTP. All Cisco level project support for LTP has been yanked recently due to limited restructuring (the other gentleman that was going to help me is no longer part of my project as well), so I'm doing this solely on my spare time. If you _want_ to fix the items, you can too -- this is an opensource project you know ;)... I am aware of the eyesores and I'll get to them as soon as I can. 1. If it breaks functionality, it needs to be fixed before commit. 2. If it's an eyesore, I'll prioritize it and fix it ASAP. BTW, AFAIK there isn't a style guide for LTP -- so before correcting me on style I'd produce a writeup stating that _this_ is how I need to code my code in order to meet LTP's standards, please. Thanks, -Garrett ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
