On Tue, Jul 21, 2009 at 2:28 PM, Mike Frysinger<[email protected]> wrote:
> On Tuesday 21 July 2009 10:21:44 Garrett Cooper wrote:
>> I was tempted to fix the format string error, but I don't know what
>> the potential implications are of switching the data type from
>> u_int64_t to unsigned long long...
>
> dont do that. just use the proper format string from inttypes.h.
> uint64_t f;
> printf("f = %"PRIu64"\n", f);
>
>> +/* Dummy function reference to avoid compiler warning from
>> linux_syscall_numbers.h. */
>> +extern void cleanup() { }
>
> this is incorrect for a few reasons. it should read:
> +/* Dummy function as syscall() from linux_syscall_numbers.h uses cleanup() */
> void cleanup() { }
> -mike
Ok. I'll fix it again, recompile, and test.
Thanks for the review Mike :) (even though it's a bit post-mortem
now). I do lack a bit when it comes to C coding style and that's one
area that I want to improve upon.
-Garrett
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
