On Thu, Jul 30, 2009 at 11:59:25PM +0530, Subrata Modak wrote:
> On Fri, 2009-07-24 at 11:24 -0700, Matt Helsley wrote:
> > On Wed, Jul 22, 2009 at 10:22:05PM +0800, nobuhiro wrote:
> > >
> > > Signed-off-by: nobuhiro <[email protected]>
> > > ---
> > > testcases/kernel/containers/pidns/Makefile | 2 +-
> > > testcases/kernel/ipc/pipeio/Makefile | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/testcases/kernel/containers/pidns/Makefile
> > > b/testcases/kernel/containers/pidns/Makefile
> > > index 4886d58..14f49da 100644
> > > --- a/testcases/kernel/containers/pidns/Makefile
> > > +++ b/testcases/kernel/containers/pidns/Makefile
> > > @@ -20,7 +20,7 @@
> > >
> > > CFLAGS += -Wall
> > > CPPFLAGS += -I../../../../include -I../libclone
> > > -LDLIBS += -L../../../../lib -L../libclone ../libclone/libclone.a -lltp
> > > -lrt
> > > +LDLIBS += -L../../../../lib -L../libclone ../libclone/libclone.a -lltp
> > > -lrt -lpthread
> >
> > I'm not sure this is correct. I just did a CVS update and grepped for
> > "pthread". I don't see a single use of pthreads in there. What output
> > suggested all of these tests need to link to pthreads? Could you at
> > least stick that in the changelog?
> >
>
> Did you reply to Mattś mail on this ?
Yes, I got a reply. Maybe it wasn't cc'd to the LTP mailing list?
Regardless, I'm satisfied with the patch itself. As I said before the
changelog would be nicer if it included a snippet of the output that
justifies it (included here for convenience):
When static linking, the pthread stuff is due to the undefined pthread
symbols
in librt.a and libgcc_eh.a.
make[4]: Entering directory
`/home/nobuhiro/git_repo/os/ltp/testcases/kernel/ipc/pipeio'
cc -Wall -static -Wall -I../../../../include pipeio.c
-L../../../../lib
-lltp -lrt -o pipeio
/usr/lib/gcc/x86_64-pc-linux-gnu/4.3.3/../../../../lib64/librt.a(aio_suspend.o):
In function `cleanup':
(.text+0xa): undefined reference to `pthread_mutex_lock'
Thanks to Nobuhiro.
Cheers,
-Matt Helsley
>
> Regards--
> Subrata
>
> > >
> > > SRCS := $(wildcard *.c)
> > > TARGETS := $(SRCS:%.c=%)
> > > diff --git a/testcases/kernel/ipc/pipeio/Makefile
> > > b/testcases/kernel/ipc/pipeio/Makefile
> > > index afd3e8d..d2a1d5f 100644
> > > --- a/testcases/kernel/ipc/pipeio/Makefile
> > > +++ b/testcases/kernel/ipc/pipeio/Makefile
> > > @@ -22,7 +22,7 @@
> > >
> > > ###########################################################################
> > > CFLAGS += -Wall
> > > CPPFLAGS += -I../../../../include
> > > -LDLIBS += -L../../../../lib -lltp -lrt
> > > +LDLIBS += -L../../../../lib -lltp -lrt -lpthread
> >
> > Same here.
> >
> > Cheers,
> > -Matt Helsley
> >
> > ------------------------------------------------------------------------------
> > _______________________________________________
> > Ltp-list mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
