On Thu, Aug 6, 2009 at 11:04 PM, Michal Simek<[email protected]> wrote:
> Hi,
>
>> On Mon, Aug 3, 2009 at 6:24 AM, <[email protected]> wrote:
>>> From: Michal Simek <[email protected]>
>>>
>>> I added support for testing ramfs and add together
>>> tests for nfs, tmpfs and ramfs.
>>
>> [...]
>>
>> Hi Michal,
>>
>> I'm looking at this code to solve another interesting problem, but
>> just out of curiosity -- why did you #define the constants instead of
>> using the definitions in sys/vfs.h? To ensure that the manpage was
>> correct :)?
>
> Not though about. Just find value and add it like for others.

It'd be better if we used #ifndef - #define - #endif though, right?

> But anyway for Ramfs I don't have that value in toolchain. For tmpfs and nfs 
> I have.
> From my quick look the problem seems to be that ramfs magic is not in 
> linux/magic.h
> but in fs/ramfs/inode.c which is wrong.

Well, that's something that should be filed as a bug and cleaned up,
right :)? It's better to have those exposed so folks can use it.

> What interesting problem?

We boot off nfs rootfs and I was trying to find a way to determine
whether or not something was initramfs, so we could call
default_rootfs() from init_post(), only when initramfs is not present
and mounted as root -- would this in fact apply?

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to