On Wed, Aug 12, 2009 at 2:09 PM, Paul Larson<[email protected]> wrote: > Garrett Cooper wrote: >> On Aug 12, 2009, at 8:13 AM, Paul Larson wrote: >> >>> Garrett Cooper wrote: >>>> On Thu, Aug 6, 2009 at 7:52 AM, Paul >>>> Larson<[email protected]> wrote: >>>>> The lib6 tests seem to fail the first pass through building for me >>>>> because ranlib does not seem to get set correctly at any point. This >>>>> seems to fix it up for me. >>>> >>>> Fixed on HEAD moments ago: >>>> >>>> gcoo...@orangebox /scratch/ltp-dev2/ltp $ cvs diff >>>> testcases/network/lib6/Makefile >>>> Index: testcases/network/lib6/Makefile >>>> =================================================================== >>>> RCS file: /cvsroot/ltp/ltp/testcases/network/lib6/Makefile,v >>>> retrieving revision 1.6 >>>> diff -r1.6 Makefile >>>> 25a26,27 >>>>> RANLIB ?= ranlib >>> The patch you checked in does not correct the build failure. >> >> Error message please? > Same error as before: > make[3]: Entering directory `/home/plars/ltp2/testcases/network/lib6' > cc -Wall -I../../../include -g -D_GNU_SOURCE -c -o runcc.o runcc.c > ar cr runcc.a runcc.o > runcc.a > make[3]: runcc.a: Command not found > make[3]: *** [runcc.a] Error 127 > make[3]: Leaving directory `/home/plars/ltp2/testcases/network/lib6' > make[2]: *** [all] Error 2 > make[2]: Leaving directory `/home/plars/ltp2/testcases/network' > make[1]: *** [all] Error 2 > make[1]: Leaving directory `/home/plars/ltp2/testcases' > make: *** [all] Error 2 > > My make-foo is a bit rusty, but I'm guessing that the higher level > export is exporting an empty RANLIB, so the RANLIB ?= ranlib is not > doing anything since RANLIB already exists.
You're right. I've just fixed it on HEAD with the following comment: Signed-off-by: Garrett Cooper <[email protected]> Index: Makefile =================================================================== RCS file: /cvsroot/ltp/ltp/Makefile,v retrieving revision 1.40 diff -u -r1.40 Makefile --- Makefile 10 Jul 2009 23:01:27 -0000 1.40 +++ Makefile 12 Aug 2009 21:27:24 -0000 @@ -7,6 +7,11 @@ CC=$(CROSS_COMPILER)gcc AR=$(CROSS_COMPILER)ar RANLIB=$(CROSS_COMPILER)ranlib +else +# RANLIB isn't a standard Make variable, which means that when it's exported +# to leaf callers as an empty value, builds fail. +# testcases/network/lib6/Makefile is a prime example. +RANLIB?=ranlib endif HAS_NUMA=$(shell sh tools/scripts/numa_test.sh) ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
