On Monday 03 August 2009 02:32:59 Garrett Cooper wrote:
> export SHELL_DEBUG=${SHELL_DEBUG:=0}
does this really need to be exported ? otherwise, the simpler way to write a
default value is:
: ${SHELL_DEBUG:=0}
there are a bunch of places this can be fixed in this file
> exists()
> {
> for cmd in $@; do
you should always use "$@", not $...@. if you actually want $@, then you
should
use $* to keep things clear.
> if ! which $cmd 2>&1 1>/dev/null; then
which is not portable. use `type` or `command`. $cmd should be quoted.
> TCID=${TCID:=}
> [ -z "$TCID" ] && TCID=${0##*/}
does this really need to be two lines ?
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
