Hi Mike, Thanks for identifying that. Fixed patch attached.
-Nobuhiro Lin -----Original Message----- From: Mike Frysinger [mailto:[email protected]] Sent: Saturday, September 12, 2009 10:28 AM To: [email protected] Cc: Shawn Hsin-Hung Lin(林信宏) Subject: Re: [LTP] [PATCH] pselect01: Fixed the checking logic to also consider some variation. On Friday 11 September 2009 09:20:33 Nobuhiro Lin wrote: > - if (total_sec >= (end - start)) > + if(((end - start) >= total_sec) && ((end - start) <= total_sec > + > +1)) please fix your style. skimping on whitespace doesnt make for smaller code. that said, your test boils down to "== total_sec" or "== total_sec + 1". might as well use that rather than confusing greater/less than comparisons. -mike
0001-pselect01-Fixed-the-checking-logic-to-also-consider-.patch
Description: 0001-pselect01-Fixed-the-checking-logic-to-also-consider-.patch
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
