On Sun, 2009-09-27 at 02:46 +0400, Andrew Vagin wrote:
> 1. check result from operation open before set flags
> 2. close descriptor and free path if set flags failed
>
> valgrind --leak-check=full --show-reachable=yes ./fsstress -d
> /home/shpagin/git-archive/ltp/testcases/kernel/fs/fsstress/tmp -l 10 -n 100
>
> ==23212== 1,134 bytes in 108 blocks are definitely lost in loss record 4 of 5
> ==23212== at 0x4A0776F: realloc (vg_replace_malloc.c:429)
> ==23212== by 0x401E6A: append_pathname (fsstress.c:528)
> ==23212== by 0x4024E3: fent_to_name (fsstress.c:760)
> ==23212== by 0x40284F: get_fname (fsstress.c:846)
> ==23212== by 0x4041E0: dread_f (fsstress.c:1757)
> ==23212== by 0x402368: doproc (fsstress.c:728)
> ==23212== by 0x401CC1: main (fsstress.c:463)
>
> Signed-off-by: Andrew Vagin <[email protected]>
Thanks.
Regards--
Subrata
> ---
> testcases/kernel/fs/fsstress/fsstress.c | 16 +++++++++++-----
> 1 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/testcases/kernel/fs/fsstress/fsstress.c
> b/testcases/kernel/fs/fsstress/fsstress.c
> index 715c08d..cf7ba76 100644
> --- a/testcases/kernel/fs/fsstress/fsstress.c
> +++ b/testcases/kernel/fs/fsstress/fsstress.c
> @@ -1764,10 +1764,6 @@ dread_f(int opno, long r)
> }
> fd = open_path(&f, O_RDONLY);
>
> - if (!setdirect(fd)) {
> - return;
> - }
> -
> e = fd < 0 ? errno : 0;
> check_cwd();
> if (fd < 0) {
> @@ -1777,6 +1773,13 @@ dread_f(int opno, long r)
> free_pathname(&f);
> return;
> }
> +
> + if (!setdirect(fd)) {
> + close(fd);
> + free_pathname(&f);
> + return;
> + }
> +
> if (fstat64(fd, &stb) < 0) {
> if (v)
> printf("%d/%d: dread - fstat64 %s failed %d\n",
> @@ -1864,8 +1867,11 @@ dwrite_f(int opno, long r)
> return;
> }
>
> - if (!setdirect(fd))
> + if (!setdirect(fd)) {
> + close(fd);
> + free_pathname(&f);
> return;
> + }
> if (fstat64(fd, &stb) < 0) {
> if (v)
> printf("%d/%d: dwrite - fstat64 %s failed %d\n",
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
