On Saturday 10 October 2009 18:02:47 Garrett Cooper wrote:
> On Sat, Oct 10, 2009 at 12:51 PM, Mike Frysinger wrote:
> > On Friday 09 October 2009 13:48:42 Garrett Cooper wrote:
> >>     I'm posting the following diff as reference (it's compressed
> >> because the entire diff is ~1.8MB) as I'm now going to commit the
> >> following to CVS after 1.25 years of anticipation waiting for this
> >> enhancement in the Makefiles to correct issues related to difficulty
> >> primarily in 1) terms of maintenance, 2) lack of out-of-build-tree
> >> support, and 3) the fact that we weren't following autoconf-like
> >> practices for installation [ties into 1) and 2)].
> >>     If there are any issues in building the sourcebase after this,
> >> please consult the TODO file in the root directory to determine
> >> whether or not it's a known issue. If the issue isn't listed there,
> >> please email the list and CC me. I ran it on Fedora 10, Gentoo Linux,
> >> and Ubuntu Feisty Fawn, so I tried to get as much coverage as possible
> >> when making these changes.
> >
> > seems like the compile step depends on install dirs.  a simple make in a
> > subdir fails with:
> > $ make
> > mkdir -p "/opt/ltp/testcases/bin"
> > mkdir: cannot create directory `/opt/ltp': Permission denied
> > make: *** [/opt/ltp/testcases/bin] Error 1
> >
> > or if prefix isnt set:
> > $ make
> > mkdir -p "/testcases/bin"
> > mkdir: cannot create directory `/testcases': Permission denied
> > make: *** [/testcases/bin] Error 1
> 
>     Both of these items requires the appropriate prefix to be put in
> config.mk, and/or the definition of DESTDIR, because the new Makefile
> infra installs directly to the destination folder.
>     I'll go and fix the latter case though...

i'm not sweating requiring the prefix to be sane via confgure/config.mk/...  
i'm saying the compile step should not be needing things in the prefix.  that 
includes the creation of the install prefix (i just did a cvs up and that 
seems to be fixed), and building against the headers/libraries.  that seems to 
be broken atm:
$ make
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall  -I//opt/ltp/include -
I../../../../include  -L//opt/ltp/lib   ptrace04.c  -laio -lltp -o ptrace04
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.1/../../../../x86_64-pc-linux-gnu/bin/ld: 
cannot find -lltp
collect2: ld returned 1 exit status
make: *** [ptrace04] Error 1

those paths against the configured prefix (/opt/ltp) should not be there.  we 
should be compiling against the local include only ($(top_srcdir)/include) and 
linking against the local lib only ($(top_builddir)/lib).

also, it seems like the lib subdir is missing a default dependency on the 
libltp.a library:
$ cd lib
$ make clean
rm -f -f libltp.a *.o *.pyc
$ make
make: Nothing to be done for `install'.
$ make libltp.a
<correct output>

actually, now that i see this output, i guess the problem is that the default 
target is "install" instead of "all" (which implies compiled local objects 
only) ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to