On Mon, Oct 12, 2009 at 10:30 PM, Mike Frysinger <[email protected]> wrote:
> On Tuesday 13 October 2009 01:22:02 Garrett Cooper wrote:
>> +do_link() {
>> +       pfix=$1; shift
>> +       ln_opts=$1; shift
>> +       limit=$1; shift
>
> any point in shifting ?  be simpler to just use $1 $2 $3

No point really -- I'll change that.

>> +       cd ${pfix}link; \
>> +       while [ $i -lt $limit ]; do \
>
> why the line continuation ?

I deleted that stupidity.

>> +                       (( lerrors++ ))
>> +               (( i++ ))
>> +       (( TST_COUNT++ ))
>
> i think you want:
>        : $(( TST_COUNT += 1 ))

Ok, dumb question again -- $(( TST_COUNT += 1 )) is the POSIX
compliant method? (( TST_COUNT++ )) works too... (I keep on forgetting
what's POSIX compliant on this item...).

I also fixed a variable not being defined too, which resulted in a cosmetic bug:

        pfix=$1; shift
        ln_opts=$1; shift
        limit=$1; shift
+       prefix_msg=$1; shift

Thanks!
-Garrett

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to