On Fri, 2009-10-09 at 15:44 +0900, Masatake YAMATO wrote: > Some of testcases for *16 and *64 system calls have not been completed yet > though my makefile trick were introduced by Suburata. *16 may not be so > important > but I'd like to complete them anyway. The first one is for getuid16. > > To apply getuid16.patch use -p0 option. > Put compat_uid.h at testcases/kernel/syscalls/utils/compat_uid.h. > Put compat_16.h. at testcases/kernel/syscalls/getuid/compat_16.h. > > > Signed-off-by: Masatake YAMATO <[email protected]>
Except the Makefile part, others would apply fine: patching file testcases/kernel/syscalls/getuid/Makefile Hunk #1 FAILED at 16. 1 out of 1 hunk FAILED -- saving rejects to file testcases/kernel/syscalls/getuid/Makefile.rej patching file testcases/kernel/syscalls/getuid/getuid01.c patching file testcases/kernel/syscalls/getuid/getuid02.c patching file testcases/kernel/syscalls/getuid/getuid03.c However, this will introduce build breaks as well: In file included from getuid01.c:119: compat_16.h:27:24: error: compat_uid.h: No such file or directory In file included from getuid01.c:119: compat_16.h:47: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘GETUID’ compat_16.h:53: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘GETEUID’ getuid01.c: In function ‘main’: getuid01.c:160: warning: implicit declaration of function ‘GETUID’ getuid01.c:175: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘long int’ make[4]: *** [getuid01] Error 1 Can you please take into account the recent changes done by Garret, and, then resend this Patch ? Regards-- Subrata > > plain text document attachment (compat_uid.h) > /* > * > * Copyright (c) Red Hat Inc., 2009 > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2 of the License, or > * (at your option) any later version. > * > * This program is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > * the GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, write to the Free Software > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ > > /* Author: Masatake YAMATO <[email protected]> */ > > #ifndef __COMPAT_UID_16_H__ > #define __COMPAT_UID_16_H__ > > > #include <asm/posix_types.h> > > > #ifdef TST_USE_COMPAT16_SYSCALL > typedef __kernel_old_uid_t UID_T; > int > UID_SIZE_CHECK(uid_t uid) > { > /* See high2lowuid in linux/highuid.h > Return 0 if uid is too large to store > it to __kernel_old_uid_t. */ > return ((uid) & ~0xFFFF)? 0: 1; > } > > #else > > typedef uid_t UID_T; > int > UID_SIZE_CHECK(uid_t uid) > { > return 1; > } > > #endif > > #endif /* __SETUID_COMPAT_16_H__ */ > plain text document attachment (compat_16.h) > /* > * > * Copyright (c) Red Hat Inc., 2008 > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2 of the License, or > * (at your option) any later version. > * > * This program is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > * the GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > * along with this program; if not, write to the Free Software > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ > > /* Author: Masatake YAMATO <[email protected]> */ > > #ifndef __GETUID_COMPAT_16_H__ > #define __GETUID_COMPAT_16_H__ > > > #include "linux_syscall_numbers.h" > #include "compat_uid.h" > > > #ifdef TST_USE_COMPAT16_SYSCALL > > UID_T > GETUID(void) > { > return syscall(__NR_getuid); > } > > UID_T > GETEUID(void) > { > return syscall(__NR_geteuid); > } > > #else > > UID_T > GETUID(void) > { > return getuid(); > } > > UID_T > GETEUID(void) > { > return geteuid(); > } > > #endif > > #endif /* __GETUID_COMPAT_16_H__ */ > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
