On Fri, Oct 16, 2009 at 11:54 PM, Garrett Cooper <[email protected]> wrote: > On Thu, Oct 15, 2009 at 12:46 PM, Cyril Hrubis <[email protected]> wrote: >> Hi! >>> >> Hmm, may be we should really move testcases/kernel/include into >>> >> $(topdir)/include or better move them them to subdir in >>> >> $(topdir)/include and >>> >> put the generated header into $(topdir)/include, it would save us some >>> >> more >>> >> complexity when creating makefiles. >>> > >>> > Cyril, >>> > Files generated at build time should _never_ live in the source >>> > directory. Otherwise tidiness becomes a serious issue, esp with source >>> > control. >>> > This can be corrected by adding this logic to a common Makefile if >>> > you like, so that way it does get picked up from one common source. >>> > This makes more sense from a design perspective. >>> >>> Ugh, I'm tired... yes, what you proposed above was correct, but >>> not complete from a submake perspective, but then again making >>> Makefiles aren't correct. I will implement the complete part this >>> weekend. > > *Mimicking Subrata* > > Thanks! (applied to cvs HEAD moments ago).
And I just applied the simple enhancement so doing submakes from a clean workspace without modifying linux_syscall_numbers.h and libltp.a will give the developer or end-user a `freebie' by cd'ing into the directories and running make prior to building the subtarget. This is all being made possible by me reviving the MAKE_DEPS variable. $(MAKE_DEPS) defines all targets that must be explicitly executed prior to $(MAKE_TARGETS). 1. I'll need to go fix any Makefile's that don't have testcase.mk included that need either of these dependencies, just for simplicity and feature parity across the repo. 2. I'll apply the same logic to the Makefile.inc stuff across the SCM to reduce inconsistencies. I can do that stuff next month because I'm going to be busy fixing the issues I've filed over the past 2 weeks that are still outstanding. Thanks, -Garrett ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
