On Tue, Oct 27, 2009 at 06:32:34PM -0700, Henry Yei wrote:
> All,
> 
> The patch attached  for ppoll01:
> 
> cleans up spacing and code style
> 
> removes unneeded/broken debug option parsing
> 
> if test fails, it prints out the last failed errno, rather than just the last 
> errno(which may have been successful)
> 
> passes in correct size of sigset_t for mips

Hi,

While you are on this one, can you cleanup the test file creation. It
currently tries to create test files in the diretory where the ppoll
executable comes from, instead of the test tmp dir ... which is just
wrong.

        static char *progdir;

        progdir = strdup(av[0]);
        progdir = dirname(progdir);

        TEST(fd = setup_file(progdir, "test.file", fpath));
        if (fd < 0)
                return 1;

progdir should be removed, and "." used instead.

Thanks.

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to