Any further work on this patch ? Regards-- Subrata
On Wed, 2009-10-28 at 12:08 -0700, Henry Yei wrote: > > -----Original Message----- > > From: Garrett Cooper [mailto:[email protected]] > > Sent: Tuesday, October 27, 2009 7:57 PM > > To: Henry Yei > > Cc: LTP Mailing List > > Subject: Re: [LTP] [PATCH][ppoll01] fix testcase 1, 5: pass correct > > value for sigset_t for mips > > > > On Tue, Oct 27, 2009 at 6:32 PM, Henry Yei <[email protected]> wrote: > > > All, > > > > > > > > > > > > The patch attached for ppoll01: > > > > > > cleans up spacing and code style > > > > > > removes unneeded/broken debug option parsing > > > > > > if test fails, it prints out the last failed errno, rather than just > > the > > > last errno(which may have been successful) > > > > > > passes in correct size of sigset_t for mips > > > > > > > > > > > > Signed-off by: Henry Yei <[email protected]> > > > > > > > > > > > > This patch was tested/passed on x86, mips(little endian), and > > ppc_82xx . > > > > 1. Please keep tst_exit() at the bottom. > > 2. Why can't we do sizeof(sigsetmask) ? > > > > Thanks, > > -Garrett > > Garrett, > > You want me to put tst_exit() at the bottom, even though it is called within > cleanup()? > You mean sizeof(sigmask) ~ sizeof(sigset_t), right? That code was commented > out since version 1.1 which I thought was odd too, so I did check > sizeof(sigmask). > However, sizeof(sigmask) on mips returns 128 which does not seem correct. I > haven't checked the other architectures, but I suspect some might have a > similar mismatch. Apparently sigset_t may have different values when returned > from glibc vs kernel space. More information from this post: > > http://lists.uclibc.org/pipermail/uclibc/2009-January/041850.html > > > > > > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Ltp-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
