-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Subrata,
Subrata Modak wrote: > On Fri, 2009-11-06 at 19:33 +0530, gowrishankar wrote: >> Giuseppe CAVALLARO wrote: >>> gowrishankar wrote: >>>> Giuseppe CAVALLARO wrote: >>>>> Regards, >>>>> Peppe >>>>> >>>> Can you please add freeing resources at the end of main. >>>> >>>> stats_container_free(&dat); >>>> stats_container_free(&hist); >>>> stats_quantiles_free(&quantiles); >>>> >>>> Also, you could set MIN_ITERATION to 10000 instead of hard coding inside >>>> main. >>>> Just a suggestion. >>> patch reattached! > > Thanks. But it fails to apply: > > patching file testcases/realtime/func/gtod_latency/gtod_latency.c > Hunk #1 succeeded at 57 (offset 1 line). > Hunk #3 succeeded at 197 (offset 1 line). > Hunk #5 FAILED at 230. > Hunk #6 succeeded at 285 (offset 2 lines). > Hunk #8 succeeded at 303 with fuzz 2 (offset 2 lines). > Hunk #9 succeeded at 313 (offset 1 line). > Hunk #10 succeeded at 337 (offset 2 lines). you are right, the ltp-full-20090731-gtod_latency_iterations.patch has to be applied patch after the two patches below: - - ltp-full-20090731-SH-atomic_add.patch - - ltp-full-20090731-tsc_splitted.patch Peppe >>> Peppe >>> >> Patch looks neat! >> >> I just recollected now that I had sent more or less same patch >> very long back, but maintainer missed it some how. >> >> http://www.opensource-archive.org/showthread.php?t=82487 >> >> Subrata ?? :) > > I apolozise to have missed to see your patches. It is rare that i miss > any patches. But, i can see that some other patch changing the same file > was ack-ed by you. You could have reminded me during that time that it > does not include changes sent by you: > > http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/realtime/func/gtod_latency/gtod_latency.c?view=log, > > Revision 1.10 - (view) (download) (annotate) - [select for diffs] > Mon Aug 3 10:37:50 2009 UTC (3 months ago) by subrata_modak > Branch: MAIN > Changes since 1.9: +4 -2 lines > Diff to previous 1.9 > This set of 3 patches adds a new API stats_container_append to libstats. This > function adds new stats_record_t to the record list in stats_container_t. It > also replaces the occurrences of data->size with data->index and modifies the > test-cases to call the append function. Changelog > --------- > - Added index to stats_container_t struct > - Added Append function to add new stats_record_t to records list of > stats_container_t > - Replaced the occurrences of data->size by data->index in libstats.c > - Modified the realtime testcases to include call to the append function. > [PATCH 3/3] libstats: Modify testcases to call the append function: This > patch modifies the testcases to call the stats_container_append function. > Signed-off-by: Kiran Prakash <[email protected]>, > Acked-by: Gowrishankar <[email protected]>, > Acked-by: Darren Hart <[email protected]>, > Acked-by: Sripathi Kodi <[email protected]>, > > Regards-- > Subrata > >> Thanks, >> Gowri >> >> >> >>>> Thanks, >>>> Gowri >>>> >>>>> ------------------------------------------------------------------------ >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> >>>>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 >>>>> 30-Day trial. Simplify your report design, integration and deployment >>>>> - and focus on what you do best, core application coding. Discover >>>>> what's new with >>>>> Crystal Reports now. http://p.sf.net/sfu/bobj-july >>>>> >>>>> >>>>> ------------------------------------------------------------------------ >>>>> >>>>> _______________________________________________ >>>>> Ltp-list mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/ltp-list > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksBaCwACgkQ2Xo3j31MSSLMswCff+LA4xYE/h9b37cMRCcjz1J2 J2wAnjwGwpggk4+H58l3/XZ5e0gQRvb4 =ZOT0 -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
