On Thu, Nov 19, 2009 at 10:00 PM, Mitani <[email protected]> wrote:
> Hi,
>
> When I ran LTP in RHEL5.4 using ltp-2009-11-19.tar.gz,
> "move_pages03" and "move_pages11" were failed in each of "syscalls" and
> "numa" tests like that:
>
> ------------
> move_pages01 1 TCONF : NUMA support not provided
> move_pages02 1 TCONF : NUMA support not provided
> chown: cannot access `move_pages03': No such file or directory
> move_pages04 1 TCONF : NUMA support not provided
> move_pages05 1 TCONF : NUMA support not provided
> move_pages06 1 TCONF : NUMA support not provided
> move_pages07 1 TCONF : NUMA support not provided
> move_pages08 1 TCONF : NUMA support not provided
> move_pages09 1 TCONF : NUMA support not provided
> move_pages10 1 TCONF : NUMA support not provided
> chown: cannot access `move_pages11': No such file or directory
> ------------
>
>
> These fails didn't occured with ltp-full-20090930.tgz, but they occured
> with ltp-full-20091031.tgz.
> With ltp-full-20090930.tgz, all of move_pagesXX (XX:01-11) were passed
> (NUMA support not provided) in my system.
>
>
> I compared these version and found out following scenarios changed.
> - ${LTPROOT}/runtest/numa
> - ${LTPROOT}/runtest/syscalls
>
>
> These scenarios are as follows, and "move_pages03" and "move_pages01"
> are revised.
>
> ------------
> # cat ./runtest/numa
> Numa-testcases numa01.sh
> move_pages01 move_pages.sh 01
> move_pages02 move_pages.sh 02
> move_pages03 cd $LTPROOT/bin && chown root move_pages03 && chmod 04755 &&
> move_pages.sh 03
> move_pages04 move_pages.sh 04
> move_pages05 move_pages.sh 05
> move_pages06 move_pages.sh 06
> move_pages07 move_pages.sh 07
> move_pages08 move_pages.sh 08
> move_pages09 move_pages.sh 09
> move_pages10 move_pages.sh 10
> move_pages11 cd $LTPROOT/bin && chown root move_pages11 && chmod 04755 &&
> move_pages.sh 11
> # cat ./runtest/syscalls | grep move_page
> move_pages01 move_pages.sh 01
> move_pages02 move_pages.sh 02
> move_pages03 cd $LTPROOT/bin && chown root move_pages03 && chmod 04755 &&
> move_pages.sh 03
> move_pages04 move_pages.sh 04
> move_pages05 move_pages.sh 05
> move_pages06 move_pages.sh 06
> move_pages07 move_pages.sh 07
> move_pages08 move_pages.sh 08
> move_pages09 move_pages.sh 09
> move_pages10 move_pages.sh 10
> move_pages11 cd $LTPROOT/bin && chown root move_pages11 && chmod 04755 &&
> move_pages.sh 11
> #------------
>
>
> I think there are two problems in each changes:
>
> - "move_pagesXX" files are in "$LTPROOT/testcases/bin" direcotory,
> not in "$LTPROOT/bin" directory.
> - "chmod" commands don't have target file.
>
>
> I don't know why these revisions are done. But if these revisions should
> be validated, they will come to work in the change like following, I think.
> I wish I can get opinion whether my revision is right or not.
>
> ============
>
> --- syscalls 2009-11-18 13:24:34.000000000 +0900
> +++ syscalls.new 2009-11-19 16:15:13.000000000 +0900
> @@ -571,7 +571,7 @@
>
> move_pages01 move_pages.sh 01
> move_pages02 move_pages.sh 02
> -move_pages03 cd $LTPROOT/bin && chown root move_pages03 && chmod 04755 &&
> move_pages.sh 03
> +move_pages03 cd $LTPROOT/testcases/bin && chown root move_pages03 && chmod
> 04755 move_pages.sh && move_pages.sh 03
> move_pages04 move_pages.sh 04
> move_pages05 move_pages.sh 05
> move_pages06 move_pages.sh 06
> @@ -579,7 +579,7 @@
> move_pages08 move_pages.sh 08
> move_pages09 move_pages.sh 09
> move_pages10 move_pages.sh 10
> -move_pages11 cd $LTPROOT/bin && chown root move_pages11 && chmod 04755 &&
> move_pages.sh 11
> +move_pages11 cd $LTPROOT/testcases/bin && chown root move_pages11 && chmod
> 04755 move_pages.sh && move_pages.sh 11
>
> mprotect01 mprotect01
> mprotect02 mprotect02
>
> --- numa 2009-11-18 13:24:34.000000000 +0900
> +++ numa.new 2009-11-19 16:15:33.000000000 +0900
> @@ -1,7 +1,7 @@
> Numa-testcases numa01.sh
> move_pages01 move_pages.sh 01
> move_pages02 move_pages.sh 02
> -move_pages03 cd $LTPROOT/bin && chown root move_pages03 && chmod 04755 &&
> move_pages.sh 03
> +move_pages03 cd $LTPROOT/testcases/bin && chown root move_pages03 && chmod
> 04755 move_pages.sh && move_pages.sh 03
> move_pages04 move_pages.sh 04
> move_pages05 move_pages.sh 05
> move_pages06 move_pages.sh 06
> @@ -9,4 +9,4 @@
> move_pages08 move_pages.sh 08
> move_pages09 move_pages.sh 09
> move_pages10 move_pages.sh 10
> -move_pages11 cd $LTPROOT/bin && chown root move_pages11 && chmod 04755 &&
> move_pages.sh 11
> +move_pages11 cd $LTPROOT/testcases/bin && chown root move_pages11 && chmod
> 04755 move_pages.sh && move_pages.sh 11
>
> ============
>
>
> In addition, please teach why this revision was performed, if all right.
> - Why do only "move_pages03" and "move_pages11" appoint another directory
> not a current directory?
> - Why "chmod" is needed?
Mitani-san,
Good catch ><... I made some really silly clerical errors in my
commits for these runtest files.
To answer your questions though:
1. I did the cd to ensure that pan is in a consistent location
when it does the chmod and to avoid having to do
"$LTPROOT/testcases/bin/move_pages{03,11}".
2. The chmod and chown to fix the ownership and to enable the
sticky bit are being done because the test does seteuid, IIRC. What I
did was moved the logic from a `build time fix' to a `run time fix',
especially because the build user may not be root, and thus couldn't
set the sticky bit for the binary.
HTH,
-Garrett
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
