Hi! > I've been looking at sources for usctest.h again today (lib/parse_opts.c) and > I > still have the feeling that this is badly written/broken code and should be > fixed but as there are thousands of tests that uses usctest interface we > should > be careful when touching these sources. So IMHO the best approach is to change > one thing at the time and see if this was a good move. > > So let's start with TEST_PAUSE macro. Accordingly to comment in the header, > this expands to the code that waits for SIGUSR1 signal (and this is not > generaly true). This macro is expanded to the int usc_global_setup_hook() > function. The function forks the program accordingly to STD_COPIES and > accordingly STD_PAUSE it sleeps for a SIGUSR1 or not (all forked instances); > it > also changes program segment size with sbrk(). > > Looking into the test sources, this is called when the test starts in order to > implement test parameters "-c n" (run n copies concurently) and "-p" (pause > test) and system variable USC_TP_SBRK. Do we need these parameters or any of > them? If you convice me that these parameters are usefull I would gladly clean > up and document code that implements TEST_PAUSE, otherwise I would vote for > removing them (or at least the useless ones). >
Okay, let me put it like this. Are parameters introduced by TEST_PAUSE really used for anything? Would anybody cry if there where removed? Would be patch removing them accepted and merged into CVS? -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
