On Tuesday 01 December 2009 17:30:33 Jiri Palecek wrote:
>  - when no interface is found tcpdump01, $IF is unset. Don't spit out
>    an error in that case
> 
> --- a/testcases/network/tcp_cmds/tcpdump/tcpdump01
> +++ b/testcases/network/tcp_cmds/tcpdump/tcpdump01
> @@ -59,7 +59,7 @@ do_setup()
>              break
>          fi
>      done
> -    if [ -z "${IF}" ]; then
> +    if [ -z "${IF:-}" ]; then
>          end_testcase "Could not identify interface"
>          exit 1
>      fi

i would stick a comment above this explaining this is needed because the 
scripts are run with `set -u`
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to