On Fri, 04 Dec 2009 20:06:40 +0100, Mike Frysinger <[email protected]> wrote:
> On Friday 04 December 2009 11:58:13 Jiri Palecek wrote: >> the makefiles install all files with executable mode by default. This >> patch >> changes it for some of the Makefiles, that install data files, which >> should IMHO not be executable. The change makes INSTALL_MODE decide the >> actual mode when it is expanded inside the install rule (depending on >> $@, >> which is the install target name). > > that's pretty fugly way to go about it. let's go the more natural route > and > have the common code default to $(INSTALL_MODE_$@) and if that's unset, > use > the default $(INSTALL_MODE). Sorry, but I don't agree with that. This is a function-like approach which is not any less "natural" than what you propose - and it makes no demands on anyone who doesn't need it, and gives great power to those who need it. The main reason I don't like the INSTALL_MODE_$@ thing, is that eg. INSTALL_TARGETS can contain wildcards (eg. dir/*.ext), and there cannot be any such thing as $(INSTALL_MODE_dir/*.ext). You would have to enumerate all data files - or all program files - which would be a chore esp. if any of these isn't known in the makefile until "make all" is ran. OTOH I would agree on some method to automagically determine the correct mode. Jiri Palecek ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
