On Fri, Dec 4, 2009 at 8:42 AM, Jiri Palecek <[email protected]> wrote: > Hello, > > the objdump tests' Makefile is disabled in the current LTP. This patch > reenables it, and makes it work (at least for me). > > Regards > Jiri Palecek > > Signed-off-by: Jiri Palecek <[email protected]> > --- > testcases/commands/ade/Makefile | 3 --- > testcases/commands/ade/objdump/Makefile | 6 +++--- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/testcases/commands/ade/Makefile b/testcases/commands/ade/Makefile > index cf7a487..9f57629 100644 > --- a/testcases/commands/ade/Makefile > +++ b/testcases/commands/ade/Makefile > @@ -24,7 +24,4 @@ top_srcdir ?= ../../.. > > include $(top_srcdir)/include/mk/env_pre.mk > > -# XXX (garrcoop): objdump's Makefile needs fixing. > -FILTER_OUT_DIRS := objdump > - > include $(top_srcdir)/include/mk/generic_trunk_target.mk > diff --git a/testcases/commands/ade/objdump/Makefile > b/testcases/commands/ade/objdump/Makefile > index 862438c..ed3ad26 100644 > --- a/testcases/commands/ade/objdump/Makefile > +++ b/testcases/commands/ade/objdump/Makefile > @@ -27,13 +27,13 @@ include $(top_srcdir)/include/mk/env_pre.mk > test: CPPFLAGS += -O > > test_arch.obj: test.o > - mv $< "$@" > + cp $< "$@" > > test_D: test.o > - $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) $@ > + $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) > > INSTALL_TARGETS := objdump01 > - > + > MAKE_TARGETS := test test_arch.obj test_D > > include $(top_srcdir)/include/mk/generic_leaf_target.mk
Just committed a similar set of fixes to what you proposed above, as the test itself wasn't clear... As noted by Jiri, the objdump tests were disabled in the infrastructure upgrade because they didn't fit exactly into the new infrastructure. 1. Makefile: Reenable the test. 2. objdump/Makefile: Fix compilation so that it deterministically compiles with -g (needed for the test, even though it currently fails because objdump expects DWARF and that's currently unsupported with ld(1) from what I've been reading). 3. objdump/test.c -> objdump/test_arch.c: for the sake of clarity and to ensure that the command doesn't conflict with test(1), rename test.c to test_arch.c. 4. objdump/objdump01: Clarify the purpose and error check --debugging in the test. Props go to Jiri for the original observations and suggestions. Signed-off-by: Garrett Cooper <[email protected]> Thanks! -Garrett ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
