On Wed, Jan 6, 2010 at 9:18 AM, Serge E. Hallyn <[email protected]> wrote: > Quoting Stephen Smalley ([email protected]): >> It seems the Makefile rewrite last October broke the selinux testsuite. >> Is it unreasonable to expect that someone who rewrote the Makefile would >> actually try running the testsuite? >> >> Please, revert the changes or fix them. >> >> See testcases/kernel/security/selinux-testsuite/README for the >> instructions. > > Seems I have a part in breakage as well. Here are patches to get the > execshare_parent to compile. > > Now to get the policy to compile... > > --- > ltp-full-20091231.orig/testcases/kernel/security/selinux-testsuite/tests/execshare/selinux_execshare_parent.c > 2009-11-03 15:07:35.000000000 -0500 > +++ > ltp-full-20091231/testcases/kernel/security/selinux-testsuite/tests/execshare/selinux_execshare_parent.c > 2010-01-06 11:58:47.000000000 -0500 > @@ -18,9 +18,12 @@ > #include <selinux/selinux.h> > #include <selinux/context.h> > #include <sched.h> > +#include <test.h> > > -int clone_fn(char **argv) > +int clone_fn(void *in) > { > + char **argv = (char **) in; > + > execv(argv[3], argv+3); > perror(argv[3]); > return -1; > @@ -73,7 +76,7 @@ int main(int argc, char **argv) > fprintf(stderr, "%s: unable to set exec context to %s\n", > argv[0], context_s); > exit(-1); > } > - pid = ltp_clone_quick(cloneflags | SIGCHLD, child_fn, argv); > + pid = ltp_clone_quick(cloneflags | SIGCHLD, clone_fn, argv); > if (pid < 0) { > perror("clone"); > exit(-1); > > --- > ltp-full-20091231.orig/testcases/kernel/security/selinux-testsuite/tests/execshare/Makefile > 2009-10-09 13:55:51.000000000 -0400 > +++ > ltp-full-20091231/testcases/kernel/security/selinux-testsuite/tests/execshare/Makefile > 2010-01-06 11:53:53.000000000 -0500 > @@ -25,6 +25,6 @@ top_srcdir ?= ../../../../. > include $(top_srcdir)/include/mk/env_pre.mk > include $(abs_srcdir)/../Makefile.inc > > -LDLIBS += -lselinux > +LDLIBS += -lselinux -lltp > > include $(top_srcdir)/include/mk/generic_leaf_target.mk
Committed. -Garrett ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
