On Tue, Dec 29, 2009 at 9:21 PM, Li Zefan <[email protected]> wrote:
> Rishikesh wrote:
>> On 12/29/2009 02:50 PM, Li Zefan wrote:
>>>> commit fe4599d210be37a7d1bb2d6a5523b9e29bbd87e1
>>>> Author: Rishikesh K Rajak<[email protected]>
>>>> Date: Mon Dec 28 15:11:54 2009 +0530
>>>>
>>>> Added check for regression and funcitonal memcg test
>>>>
>>>>
>>> You should add your Signed-off-by.
>>>
>>
>> Sending a fresh patch with signed-off added. Also combined both the
>> patches in one & ported to latest intermediate ltp release.
>>
>
> Acked-by: Li Zefan <[email protected]>
These checks are wrong for positive cases. Please do something
like the following (I committed it to the regression script as an
example):
! if [ ! "grep -w memory /proc/cgroups | cut -f4" == "1" ]
then
! echo "WARNING:";
! echo "Either Kernel does not support for memory resource
controller or feature not enabled";
! echo "Skipping all memcgroup testcases....";
exit 0
fi
--- 31,43 ----
export TST_COUNT=1
! if [ "$(id -ru)" != 0 ]; then
tst_brkm TBROK ignored "Test must be run as root"
exit 0
fi
! if [ "$(grep -w memory /proc/cgroups | cut -f4)" != "1" ]
then
! tst_resm TCONF "Either memory resource controller kernel support absent"
! tst_resm TCONF "or feature is not enabled; skipping all
memcgroup testcases."
exit 0
fi
Please ignore the id -ru noise.
Thanks,
-Garrett
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
