Hi,
There is a problem about "make clean"(./Makefile), I think.
Before the following fix added at 12/11/2009, "/opt/ltp/" directory
was deleted by "make clean":
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/Makefile?r1=1.53&r2=1.54
But after this fix, "make clean" could not remove "/opt/ltp/" directory.
If we test new release cvs and there are fixes about permissions
in new cvs, we can't do the test correctly.
Because, if "/opt/ltp/" directory remained and new cvs's file
has same time-stamp and different permissions from old cvs's file,
the install ended with "make: Nothing to be done for `install'."
message and this new file can't be installed.
Then test cases that fixed about permissions ended in "FAIL".
In recent cvs, To test correctly, we must remove "/opt/ltp/" directory
by manual operation before trying "make install".
I think that it is right specification to remove "/opt/ltp/" directory
when "make clean" is executed.
This problem occurred because "INSTALL_IN_BUILD_TREE := 1" is defined
in "./include/mk/env_pre.mk" included in "${LTPROOT}/Makefile", I think.
"$(prefix)" of a judgment of "ifeq ($(strip $(DESTDIR)$(prefix)),)"
doesn't have value, therefor the result of the judgment becomes "true",
and "INSTALL_IN_BUILD_TREE := 1" was defined.
So, it is neccessary to define "$(prefix)" by including "./include/mk/
config.mk" before including "./include/mk/env_pre.mk", isn't it?
The following patch can fix this problem:
============
--- Makefile.orig 2010-01-09 17:37:04.000000000 +0900
+++ Makefile 2010-01-12 09:49:29.000000000 +0900
@@ -27,6 +27,7 @@
top_srcdir ?= $(CURDIR)
+include $(top_srcdir)/include/mk/config.mk
include $(top_srcdir)/include/mk/env_pre.mk
include $(top_srcdir)/include/mk/automake.mk
============
Thank you--
-Tomonori Mitani
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
