On Tue, Feb 16, 2010 at 11:46 PM, Rishikesh <[email protected]> wrote: > On 02/10/2010 03:16 PM, Shi Weihua wrote: >> mainline commit da15cfdae03351c689736f8d142618592e3cebc3 >> (subject: time: Introduce CLOCK_REALTIME_COARSE) >> added two clocks (CLOCK_REALTIME_COARSE/CLOCK_MONOTONIC_COARSE) in >> 2.6.32-rc1, but it has not been responded in ltp. then, the following >> error message occured. >> ----- >> clock_gettime03 3 TFAIL : failed to produce expected error [expected >> errno = 22 (Invalid argument), TEST_RETURN = 0]: TEST_ERRNO=???(0): Success >> clock_gettime03 4 TFAIL : failed to produce expected error [expected >> errno = 22 (Invalid argument), TEST_RETURN = 0]: TEST_ERRNO=???(0): Success >> timer_create04 1 TFAIL : didn't fail as expected [expected errno = 22 >> (Invalid argument)]: TEST_ERRNO=???(95): Operation not supported >> timer_create04 2 TFAIL : didn't fail as expected [expected errno = 22 >> (Invalid argument)]: TEST_ERRNO=???(95): Operation not supported >> ----- >> >> Following patch fixed this bug. and, passed on 2.6.32-rc1, 2.6.33-rc6, >> 2.6.23.1-42.fc8. >> > > Can anyone provide their review & Acked ? > > Thanks "Shi Weihua" for patch.
1. Please provide before and after (once the items were fixed) output. 2. *sigh* These constants should be autoconf conditionalized -- otherwise when Linux devs decide to change their minds about the values of the constants or the values are different on different architectures you'll run into red-herring errors. The test should be resistant to this behavior, but currently isn't. This would also prevent `ENOSYS'-like errors from showing up on kernels < 2.6.32-rc1. Thanks, -Garrett ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
