Quoting Rishikesh K Rajak ([email protected]): > On Wed, Mar 03, 2010 at 01:14:12AM -0800, Garrett Cooper wrote: > > Yes -- and I think this is because the constants no longer have > > the same name: > > > > http://fxr.watson.org/fxr/source/include/linux/prctl.h?v=linux-2.6#L68 > > > > Note -- CAP_BSET_DROP should be: PR_CAPBSET_DROP, etc. > > > > Which is why I stress _not_ putting these hardcoded constants in > > test files (POLLHDRDUP -- or whatever it was in ppoll01 -- is the only > > real violation I can remember OTOH that I need to clean up > > eventually). We need to be consistent with any and all documentation > > provided to end-developers or we [LTP] are going to shoot ourselves in > > the foot if and when the underlying functionality changes. > > I'll update the tests this weekend, but I would like it if someone > > test the tests on an outdated distro (RHEL 4.x?) once I provide a > > Hi Garret, > > Can you please look this again ?
Wait, what? Was the original complaint just about a #warning? Note that it will #warn but then go ahead and define it, so there should not be a real problem. Anyway I'll try to get time tomorrow to rewrite this to use the constants from the new securebits.h (which may not be in sys/ yet, but is in linux/ atm and will show up under sys/ at some point). If Garret could help me with doing an automate thingamagiggy to detect whether prctl(CAP_BSET_DROP) returns -ENOSYS and not compile/install/run the tests in that case, that'd be great. And maybe I'll finally implement some of the new securebits testcases I spelled out a year or two ago. thanks, -serge ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
