2010/11/8 Bian Naimeng <[email protected]>: > > Garrett Cooper wrote: >> On Tue, Nov 2, 2010 at 2:07 AM, Bian Naimeng <[email protected]> wrote: >>> The default value of the mutex's protocol shall be PTHREAD_PRIO_NONE, >>> so pthread_mutex_getprioceiling should return EINVAL. >>> >>> Signed-off-by: Bian Naimeng <[email protected]> >>> >>> --- >>> .../interfaces/pthread_mutex_getprioceiling/1-1.c | 30 >>> ++++++++++++++++++++ >>> 1 files changed, 30 insertions(+), 0 deletions(-) >>> >>> diff --git >>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/1-1.c >>> >>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/1-1.c >>> index d9251e6..65c8c6b 100644 >>> --- >>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/1-1.c >>> +++ >>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/1-1.c >>> @@ -18,6 +18,7 @@ >>> #include <pthread.h> >>> #include <stdio.h> >>> #include <sched.h> >>> +#include <errno.h> >>> #include "posixtest.h" >>> >>> int main() >>> @@ -29,6 +30,7 @@ int main() >>> return PTS_UNRESOLVED; >>> #endif */ >>> >>> + pthread_mutexattr_t mattr; >>> pthread_mutex_t mutex; > > ... snip ... > > >>> + >>> + /* Get the prioceiling of the mutex. */ >>> if(pthread_mutex_getprioceiling(&mutex, &prioceiling) != 0) >>> { >>> printf("Test FAILED: Error obtaining the priority >>> ceiling\n"); >> >> A patch similar to this will be committed soon. The above patch >> has several correctness issues with perror (you have to capture the >> error and play it back via strerror), and the original test author >> accidentally mixed up one of the requirements between >> pthread_mutex_getprioceiling and pthread_mutexattr_getprioceiling as >> well by accident. This helped unroot a requirements issue on FreeBSD >> with PTHREAD_PRIO_INHERIT, and it might so similar on Linux. > > OK. I think it's better if you can send your patch at this thread. ^_^
http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp.git;a=commit;h=68332a1 >> Partial credit will be `awarded' for having keen eyes on this >> issue though :). > > Thanks very much. ^_^ No problem. Here's the other commit (because I forgot to mention you in the first one ><): http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp.git;a=commit;h=17fb758 Cheers! -Garrett ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
