On Thu, Nov 11, 2010 at 12:08 AM, Carmelo AMOROSO <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 11/11/2010 8:57 AM, Subrata Modak wrote: >> On Tue, 2010-11-09 at 12:24 +0100, Carmelo AMOROSO wrote: >> On 10/4/2010 9:05 PM, Hannu Heikkinen wrote: >>> On 04/10/10 15:04 +0200, Carmelo AMOROSO wrote: >>> -clip- >>> > >>> > Hannu, >>> > I don't think that it is a good to force the alignment; we could need to >>> > write a test case that calls LTP_clone with an unaligned stack just to >>> > test the behavior of the clone implementation. >>> > >>> > Likely, it should be useful to add a check inside the C lib clone >>> > implementation (arch specific) to protect against unaligned stack, but >>> > this is a different matter. >>> > >>> > I would just leave the LTP_clone passing the argument to the clone as >>> > they came from the caller. >>> > >>> > Regards, >>> > Carmelo >>> > >> >>> Hi Carmelo, >> >>> you've got point, yes. I was just so worried about the fact that in ARM >>> architectures that previous eg clone02 failed due to alignment errors. >>> But your fix of course fixed that issue, and it gives as a possiblity >>> to make test case against alignment issues, quite right. >> >>> br, >>> Hannu >> >> >> Folks, >> any change to get this included for the next release ? >> >>> Did we miss any patch here ? >> > > I think so: this one > http://sourceforge.net/mailarchive/forum.php?thread_name=4CA09D4D.6050708%40st.com&forum_name=ltp-list
Is the above patch endian agnostic? ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
