Cyril Hrubis wrote:
> Hi!
>> Destroy mutex an mutex_attr object at end of test.
>>
>> Signed-off-by: Bian Naimeng <[email protected]>
>>
>> ---
>>  .../interfaces/pthread_mutex_getprioceiling/3-1.c  |    2 ++
>>  .../interfaces/pthread_mutex_getprioceiling/3-2.c  |    3 +++
>>  .../interfaces/pthread_mutex_getprioceiling/3-3.c  |    3 +++
>>  3 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-1.c
>>  
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-1.c
>> index d96ae43..5267b63 100644
>> --- 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-1.c
>> +++ 
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-1.c
>> @@ -62,6 +62,8 @@ main(void)
>>      } else
>>              printf("pthread_mutex_getprioceiling passed unexpectedly\n");
>>  
>> +    (void) pthread_mutex_destroy(&mutex);
>> +
> 
> Please never use useless cast like this.
> 

 Yes,thanks for your review. 
 I will check my patch by kernel's checkpatch.pl before post it next time.

>>      return (error == EINVAL ? PTS_PASS : PTS_FAIL);
>>  #else
>>      printf("pthread_mutex_getprioceiling not supported");
>> diff --git 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-2.c
>>  
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-2.c
>> index 843c048..afa12c1 100644
>> --- 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-2.c
>> +++ 
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-2.c
>> @@ -75,6 +75,9 @@ main(void)
>>      } else
>>              printf("pthread_mutex_getprioceiling passed unexpectedly\n");
>>  
>> +    (void) pthread_mutexattr_destroy(&mutex_attr);
>> +    (void) pthread_mutex_destroy(&mutex);
>> +
> 
> And here.
> 
>>      return (error == EINVAL ? PTS_PASS : PTS_FAIL);
>>  #else
>>      printf("pthread_mutex_getprioceiling not supported");
>> diff --git 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-3.c
>>  
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-3.c
>> index cf46f77..4aa6b1c 100644
>> --- 
>> a/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-3.c
>> +++ 
>> b/testcases/open_posix_testsuite/conformance/interfaces/pthread_mutex_getprioceiling/3-3.c
>> @@ -76,6 +76,9 @@ main(void)
>>      } else
>>              printf("pthread_mutex_getprioceiling passed unexpectedly\n");
>>  
>> +    (void) pthread_mutexattr_destroy(&mutex_attr);
>> +    (void) pthread_mutex_destroy(&mutex);
>> +
> 
> And here.
> 
>>      return (error == EINVAL ? PTS_PASS : PTS_UNRESOLVED);
>>  #else
>>      printf("pthread_mutex_getprioceiling not supported");
>> -- 
>> 1.7.0.4
> 

-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to