> > + /* message returned from parse_opts */ > > + char *msg; > > + > > Well I think there is no need for that comment, everybody sees that > this > is a message returned from parse_opts. OK.
> > + /* loop counter */ > > + int lc; > > Same here, no need to say "this is a counter". Save comments for > places > where they are really needed. OK. > > + if (addr == MAP_FAILED) > > + tst_brkm(TBROK|TERRNO, NULL, "mmap"), exit(1); > > You should use tst_brkm(TBROK|TERRNO, tst_exit, "mmap") here. As > tst_brkm() exits when pointer to cleanup is not NULL. Yes, just figured that out. CAI Qian ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
