On Wednesday, December 29, 2010 04:35:29 Vivi wrote:
> --- testcases/kernel/syscalls/adjtimex/adjtimex02.c
> +++ testcases/kernel/syscalls/adjtimex/adjtimex02.c
> @@ -122,12 +122,7 @@
>         void (*cleanup) ();
>         int exp_errno;
>  } test_cases[] = {
> -#ifndef UCLINUX
> -       /* Skip since uClinux does not implement memory protection */
> -       {
> -       (struct timex *)-1, NULL, NULL, EFAULT},
> -#endif
> -       {
> +       { (struct timex *)-1, NULL, NULL, EFAULT},{
>         &buff, setup2, NULL, EINVAL}, {
>         &buff, setup3, NULL, EINVAL}, {
>         &buff, setup4, NULL, EINVAL}, {
> @@ -159,7 +154,18 @@
>                 Tst_count = 0;
> 
>                 for (i = 0; i < TST_TOTAL; ++i) {
> +#ifdef UCLINUX
>                         /*
> +                        * Skip first case since uClinux does not implement
> +                        * memory protection.
> +                        */
> +                       if (i == 0) {
> +                               tst_resm(TCONF, "uClinux does not
> implement" +                                               " memory
> protection."); +                               continue;
> +                       }
> +#endif

we should be able to handle bad pointers like -1 and NULL.  the kernel's check 
access func should force EFAULT.  so why do we need this new if code ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to