On Mon, Jan 10, 2011 at 10:43 AM, Cyril Hrubis <[email protected]> wrote:
> Hi!
>> > I still could not compile the latest git. I've got a bunch of:
>> >
>> > pipe declared with warn_unused_result
>> > write declared with warn_unused_result
>> > read declared with warn_unused_result
>>
>> Now you know why I used void casts in a few spots :). Some are of value,
>> some are fud.
>
> The problem seems to be that in different versions of libc different
> calls are marked with warn_unused_result. I'm still thinking if -Werror
> is right default for git tree. And I'm almost sure that it's wrong for
> releases.
Agreed, but people need to turn it on before committing test code, so
that their code doesn't introduce any new warnings.
>> Ok. It would be nice to have a summary email (off-list) with all of
>> these warnings, as they can lead to really bad problems. I may do like
>> I've done in some directories as well and add -Wno-error with a
>> comment stating why things were done that way.
>
> Will send.
Thanks. Subrata sent me a bunch of warnings-related errors so I'll
need to follow up on them. Now that tst_brk is reentrant (for better
or for worse -- I needed to do this so people could use SAFE_CLOSE,
etc in cleanup functions otherwise the compiler would whine that code
doesn't return), the compiler isn't smart enough to realize that the
following will always result in an immediate exit:
int
main(void)
{
tst_brkm(TCONF, NULL, "gcc is dumb");
}
And thus always whines because it's missing an explicit return
directive (this was gcc 4.4.5 on Fedora 13).
> BTW: just now, you are missing SAFE_SETEGID and SAFE_SETEUID implementation
> so compilation stops at fchown04.c
Subrata noticed the same. Fixed.
Thanks!
-Garrett
------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
