On Friday, January 14, 2011 02:54:47 Garrett Cooper wrote:
> On Wed, Dec 29, 2010 at 1:35 AM, Vivi <[email protected]> wrote:
> > LTP test case utimes01.c can't build in uclinux as it failed in file
> > common_j_h.c.
> > Fix this by diable fork related part in uclinux platform.
> > 
> > --
> > Index: testcases/kernel/syscalls/utils/common_j_h.c
> > ===================================================================
> > --- testcases/kernel/syscalls/utils/common_j_h.c
> > +++ testcases/kernel/syscalls/utils/common_j_h.c
> > @@ -115,6 +115,7 @@
> >  /*
> >   * Generate a child process which will send a signal
> >   */
> > +#ifndef UCLINUX
> >  pid_t create_sig_proc(unsigned long usec, int sig, unsigned count)
> >  {
> >         pid_t pid, cpid;
> > @@ -142,6 +143,7 @@
> >                 return cpid;
> >         }
> >  }
> > +#endif
> > 
> > 
> >  /*
> > @@ -351,6 +353,7 @@
> >  /*
> >   * Get unexist pid
> >   */
> > +#ifndef UCLINUX
> >  pid_t get_unexist_pid(void)
> >  {
> >         pid_t pid;
> > @@ -368,4 +371,4 @@
> >                 return pid;
> >         }
> >  }
> > -
> > +#endif
> 
>     This will break more testcases than it's worth. Please revise your
> strategy of fixing the UCLINUX testcases.

in this case, it isnt possible.  this common file provides symbols we need 
along with ones we dont, so the whole thing gets linked into tests.  the only 
way to fix it to avoid #ifdef's is to split the fork-related symbols into 
their own file.  that way the linker wont attempt to link in the unused 
objects from the library archive because no test we care about will pull it 
in.  but i guess that qualifies as a "revision" ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to