On Tue, Feb 22, 2011 at 1:52 AM, Cristian Greco <[email protected]> wrote:
> Hi,
>
> please consider the following patch for the 'clone06' syscall test.
>
> When running the test on a remote host with an ssh command the TERM 
> environment
> variable is not available. Use PWD instead, with a buffer size of MAXPATHLEN.
>
> This is to show how using the TERM variable results in unexpected behavior:

    Depending on $PWD, $TERM, etc isn't smart as they're controlled by
the shell and external sources and can be modified out from under you
(there's some recent discussion on the opengroup list that has
transpired related to $PATH, $PWD, etc).
    How about this instead:

1. unset a predetermined env variable if it's present.
2. set it to a known value
3. Make sure that the env variable set in 2. matches both in the child
and parent.

    If you submit this patch, I'll gladly commit it because it's more
sane than the current test code.
Thanks,
-Garrett

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to