On Thu, Feb 24, 2011 at 9:57 AM, Shubham Goyal
<[email protected]> wrote:
> Hi Harsh/Cyril,
>
> The below changes make the files inconsistent WRT other function definitions
> and calls:-
>
> 1) Other functions in '/lib/tst_is_cwd.c' still use '? 1 : 0'. Yes this is
> redundant but if we remove this from the newly added function, I believe we
> should sync other functions too
> by removing '? 1 : 0'.
These APIs should just be simplified to true (non-zero) / false
(zero). There's no need for complicating the APIs with 0/1.
> 2) Keeping the comments in utime0*.c files does not harm us, i think...
>
> The idea is to maintain coherency here.
Yes, and it also is to simplify life, reduce wasted space on disk,
the repo, etc because there are a ton of these comments all over the
place because people copied them verbatim from the example template
(even though, again... they're just there to handhold someone
producing the example).
Thanks,
-Garrett
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
