On Wed, 2011-04-06 at 15:14 +0200, Cyril Hrubis wrote:
> Hi!
> > +struct syscall_info {
> > +   char            *sy_name;
> > +   int             sy_type;
> > +   struct status   *(*sy_syscall)();
> > +   int             (*sy_buffer)();
> > +   char            *(*sy_format)();
> > +   int             sy_flags;
> > +   int             sy_bits;
> > +};
> 
> Ideally these callbacks should have defined their parameters too.
> Otherwise the compiler can't check if we passed somehow correct
> parametetrs. Somethink like (*fn)(int, void*, char); should be enough.
> 

You're right, I missed that.  I will fix that and re-post this patch.
Thank you for the review.

                                        -Alex


------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to