On Tue, Jul 12, 2011 at 9:01 AM, Carmelo AMOROSO <[email protected]> wrote:
> On 12/07/2011 16.38, Garrett Cooper wrote:
>> On Tue, Jul 12, 2011 at 1:45 AM, Francesco RUNDO <[email protected]>
>> wrote:
>>> From: Francesco Rundo <[email protected]>
>>>
>>> The "kill05" testcase checks if EPERM is correctly raised by the system.
>>> The testcase manages the error exit codes correctly while it didn't return
>>> any exit code in case of no errors occured i.e. the system has raised EPERM.
>>> The correct exit-code "TPASS" has been added in case of the test works fine
>>> without
>>> errors.
>>>
>>> Signed-off-by: Francesco Rundo <[email protected]>
>>> Reviewed-by: Carmelo Amoroso <[email protected]>
>>
>> Please properly styleize this; this doesn't conform to Linux
>> coding standards..
>
> I've noted there is a trailing white space ?
> is this the only problem ?
No. Many software projects written in C, python, etc don't allow
conditionals with inline test statements, e.g.
if (foo) bar;
This is almost always done like 1):
if (foo)
bar;
or 2):
if (foo) {
bar;
}
See K&R and the LKML for more details on what should be done.
Thanks,
-Garrett
------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
