-----Original Message----- From: Cyril Hrubis [mailto:[email protected]] Sent: Thursday, July 14, 2011 12:32 PM To: Francesco RUNDO Cc: [email protected] Subject: Re: [LTP] [PATCH] kill05: Added proper return code (TPASS) if testcase exit without errors.
>>Hi! >> Thanks for your comment. [snip] >>Okay, so the commit description was a bit misleading as return value is >>integer nuber returned after process has ceased to exist. I would rather >>change it to "kill05 didn't print ...". Hmmm....I'm not sure about that....is not only a proper "print" issue as the testcase should return a "well defined" LTP error code i.e. TAPSS/TFAIL/TBROK etc... In the lib/tst_res.c, the error code used in the tst_resm()[internally by "tst_res()"] is used to setup the "T_exitval" variable which is used to define the LTP testcase exit code in the "tst_exit()". Correctly, in the "kill05" test, each wrong scenario is properly managed with a tst_resm(TFAIL,"......") and so on. Why it didn't the same(with tst_resm(TPASS,"...")) in case of no errors ? Ok about your comment for the default LTP setup but I think the "kill05" test(or generally speaking, each LTP testcase) shouldn't make any assumption about LTP default settings as it could changes.... Each test should set proper exit error code according to the obtained results/expected ones. Thanks FrancescoR -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
