Hi! > Modified ssh03 to unset TCtmp. On a system running the latest > selinux mls policy the call to tst_setup in the cmdlib.sh script > with the TCtmp variable still set with the TEST_USER directory will > result in the directory being created with the context of the logged > in user (i.e. administrator running the test > ...staff_u:object_r:home_root_t:SystemLow) when the useradd is run > afterwords the directory will already exist but the context of > directory /home/ssh_user3 should be > user_u:object_r:user_home_dir_t:SystemLow-SystemHigh. Now when the > test is run to ssh login with the valid password the test will fail > due to not being able to change to the user directory which is > caused by a mismatched context. The unset of TCtmp will prevent > this. This does not appear to be detrimental to systems running with > a targeted policy and should have no ill affect systems not running > selinux, although a test could be placed around the unset to > determine if selinux is running and the mls policy is in use. > > Signed-off-by James Czyzak <[email protected]> > <mailto:[email protected]> > > diff --git a/testcases/network/tcp_cmds/ssh/ssh03 > b/testcases/network/tcp_cmds/s > index 8fbca34..a75032c 100755 > --- a/testcases/network/tcp_cmds/ssh/ssh03 > +++ b/testcases/network/tcp_cmds/ssh/ssh03 > @@ -42,7 +42,7 @@ do_setup() > TCtmp=/home/$TEST_USER > > rm -Rf $TCtmp > - > + unset TCtmp > tst_setup >
What about not setting the TCtmp in the first place. Change it from: TCtmp=/home/$TEST_USER rm -Rf $TCtmp unset $TCtmp to: rm -Rf /home/$TEST_USER And the Signed-off-by line is missing double colon and there is mailto html tag that shouldn't be there. I wonder why people aren't using git commit -s and git format-patch to generate correct patches, which is easier than doing them by hand... -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
