On Thu, 25 Aug 2011 12:14:03, Cyril Hrubis <[email protected]> wrote: > To: Lucy Liang <[email protected]>
Hi Cyril, Lucy was a summer intern here at IBM, but her internship has ended. I'll try to resolve any open issues with her pounder patch submission. Please direct any future comments to me. > > diff --git a/tools/pounder21/build_scripts/ltp > > b/tools/pounder21/build_scripts/ltp > > index 68dcdbe..70defe4 100755 > > --- a/tools/pounder21/build_scripts/ltp > > +++ b/tools/pounder21/build_scripts/ltp > > @@ -55,23 +55,24 @@ fi > > > > # NAK the setregid EPERM -> EINVAL patch, because it's > > # broken on 2.6! May be fixed some time after 20050804 release. > > -if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; then > > - echo "Patching some holes in ltp..." > > - cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c > > testcases/kernel/syscalls/setregid/setregid02.c.pounder > > - patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch > > - RESULT=$? > > - if [ $RESULT -ne 0 ]; then > > - echo Patching failed. > > - exit 1 > > - fi > > -fi > > +#if [ ! -e "testcases/kernel/syscalls/setregid/setregid02.c.pounder" ]; > > then > > +# echo "Patching some holes in ltp..." > > +# cp -pRdu testcases/kernel/syscalls/setregid/setregid02.c > > testcases/kernel/syscalls/setregid/setregid02.c.pounder > > +# patch -p1 < $POUNDER_SRCDIR/ltp-setregid-fix.patch > > +# RESULT=$? > > +# if [ $RESULT -ne 0 ]; then > > +# echo Patching failed. > > +# exit 1 > > +# fi > > +#fi > > Patching LTP before build from this build script is not really long term > solution. We should get these patches applied to LTP (as it should have > been done long time ago) and drop this logic entrirely. I agree that this smells like a workaround, not a long term solution. I'll investigate whether the setregid02 patch is still needed or not, then I'll resubmit this patch. ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
