On 09/11/2011 10.15, Cyril Hrubis wrote: > Hi! >>>>> Right, but there is one more thing to fix. >>>>> >>>>> The Version is generated from Changelog, which is abandoned for some >>>>> time. But we introduced a VERSION file that carries latest version. So >>>>> the best woul be to drop Changelog completly and use the VERSION file >>>>> instead, anybody objects to that? >>>> >>>> I'd just generate the version like so: >>>> >>>> VERSION ?= $(shell echo ltp-nightly-`env LANG=C date +%Y%m%d`) >>>> >>>> in the Makefile, or something like that... I just did it based on the >>>> ChangeLog as it was the defacto source of truth in the LTP 'release >>>> process' (which fizzled after Subrata couldn't lead that effort >>>> anymore). >>> >>> Now we have the VERSION file, that should defacto carry on that >>> information for the future. So there is no problem with that, changing >>> 'head ChangeLog' to 'cat VERSION' should be enough. Maybe it would be >>> nice to use 'git describe' for builds from git repository too. >>> >> I'd propose to remove VERSION from the git and let the buildsys to >> create it at install time. >> >> Some like that: >> >> .PHONY: VERSION >> VERSION: >> git describe --abbrev=0> $@ >> >> At the end it will replace the old file 'Version'. >> > > Hmm, that wouldn't work for released tarbals that are shipped without > the .git/ directory. We need to look if there is a git repository first > and then decide to use VERSION or git describe. I'll fix these soon. >
I was proposing to create the VERSION from the git in the install step, and then package it with the released tarball (out of git). cheers, carmelo ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
