On 11/16/2011 11:32 AM, Wanlong Gao wrote: > On 11/16/2011 10:50 AM, Caspar Zhang wrote: > >> On 11/15/2011 09:38 PM, Caspar Zhang wrote: >>> >>> current zram test is broken: >>> >>> * At the end of test, error message printed: >>> ERROR: Module zram is in use >>> this is because the mapped area `s' is not freed yet. This patch unmaps >>> it before calling `rmmod zram'. >>> >>> * Sometimes `if (access() && errno == ENOENT)' doesn't work due to errno >>> not correctly captured. >>> >>> * argument passing to memset() is incorrect. >>> >>> The fixes to above issues are all integrated into this patch and the >>> patch is tested by myself. >>> >>> Signed-off-by: Caspar Zhang <[email protected]> >>> --- >>> testcases/kernel/mem/zram/zram01.c | 31 +++++++++++++++++++++++-------- >>> 1 files changed, 23 insertions(+), 8 deletions(-) >>> >> Sorry, this patch needs an update for fixing a potential forever loop, >> will post a new version soon. > > > IMO, you can format and post patch with *git send-email* instead of attach it, > it'll be more convenience to comment.
Hi, I did use git send-email. And I followed the style-guide.txt: "Guidelines for submitting patches are as follows: [snip] 4. Format the email with +git format-patch --attach+ command ." Thanks, Caspar ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
