On Monday 09 January 2012 02:29:05 Eryu Guan wrote: > On Mon, Jan 09, 2012 at 02:50:21PM +0800, Peng Haitao wrote: > > + if ((tst_kvercmp(3, 0, 0)) >= 0) > > + exp_eno = ENODATA; > > + else > > + exp_eno = EPERM; > > I think some comments describing why the comparison is needed will be > better, the commit message will be fine here. > > Or you can put the reason at the beginning of the test case along with > the test descriptions.
a comment right above this section of code would be best. less likely to bitrot or get loss in the future. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
