Jan Stancek said the following on 2012-1-17 21:42:
> 
>> +    echo $1 > memory.limit_in_bytes
>> +    if [ -z "$4" -a $4 -eq 1 ]; then
>> +            echo $1 > memory.memsw.limit_in_bytes
>> +    fi
>> +
> 
> 1. Can this condition ever be true?

This will be always false:(
should be:
[ -n "$4" -a $4 -eq 1 ]

I modify to: 
[ $4 -eq 1 ]

> 2. memory.memsw.limit_in_bytes does not exist unless
> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED is set.
> Looking at RHEL6 and Fedora16 I believe it's off, because
> "memory.memsw.limit_in_bytes" is not present.
> 

CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED is added in kernel 2.6.37-rc4.

In RHEL6.1 and RHEL6.2, CONFIG_CGROUP_MEM_RES_CTLR_SWAP is set.
In Fedora16,CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED is not set.

> I ran memcg_function_test.sh with your patch (2/8) in loop
> during lunch, all passed (kvm, RHEL6, 2.6.32-155.el6.x86_64).
> 

Thanks.

-- 
Best Regards,
Peng


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to