On 02/17/2012 02:09 PM, Zhouping Liu wrote:
> In the patch<9b70f0970>, I used numa_max_node(), which's included in <numa.h>,
> but I forgot to add precompiled header: HAVE_NUMA_H, the patch fixed it.
>
> Signed-off-by: Zhouping Liu <[email protected]>
Hi all, after discussed with Zhouping, we agreed to withdraw this patch,
since
1) the patch removes count_numa() function when HAVE_NUMA_H not defined,
it might cause some compilation problem if a new case uses count_numa()
function.
2) in some conditions, we need to use specific node(s), while, as we
know, some systems have noncontinuous nodes or not started from 0, so
it's necessary to store nodes in an array and nodes taken from that
array must be real-existed.
I've submitted an updated patch, please review that one instead.
Thanks,
Caspar
> ---
> testcases/kernel/mem/lib/mem.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
> index 25cdfd4..3843785 100644
> --- a/testcases/kernel/mem/lib/mem.c
> +++ b/testcases/kernel/mem/lib/mem.c
> @@ -148,6 +148,7 @@ void testoom(int mempolicy, int lite, int numa)
> oom(KSM, mempolicy, lite);
> }
>
> +#ifdef HAVE_NUMA_H
> long count_numa(void)
> {
> int nnodes = 0;
> @@ -161,6 +162,7 @@ long count_numa(void)
>
> return nnodes;
> }
> +#endif
>
> int path_exist(const char *path, ...)
> {
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
