Hi!
> >>diff --git a/testcases/kernel/syscalls/clone/clone06.c
> >>b/testcases/kernel/syscalls/clone/clone06.c
> >>index 5db183b..50c8ef3 100644
> >>--- a/testcases/kernel/syscalls/clone/clone06.c
> >>+++ b/testcases/kernel/syscalls/clone/clone06.c
> >>@@ -192,18 +192,16 @@ void cleanup()
> >> int child_environ(void)
> >> {
> >>
> >>- char var[MAX_LINE_LENGTH];
> >>+ char *child_env;
> >>
> >> /* Close read end from child */
> >> if ((close(pfd[0])) == -1) {
> >> tst_brkm(TBROK|TERRNO, cleanup, "close(pfd[0]) failed");
> >> }
> >>
> >>- if ((sprintf(var, "%s", getenv("TERM") ? : ""))<= 0) {
> >>- tst_resm(TWARN|TERRNO, "sprintf() failed");
> >>- }
> >>+ child_env = getenv("TERM") ? : "";
> >>
> >>- if ((write(pfd[1], var, MAX_LINE_LENGTH)) == -1) {
> >>+ if ((write(pfd[1], child_env, MAX_LINE_LENGTH)) == -1) {
> >> tst_resm(TWARN|TERRNO, "write to pipe failed");
> >Hmm, that one is wrong too, as you write MAX_LINE_LENGTH bytes
> >you write bytest __after__ the buffer.
> >
> I see...
> Whould then original patch
>
> - if ((sprintf(var, "%s", getenv("TERM") ? : "")) <= 0) {
> + if ((sprintf(var, "%s", getenv("TERM") ? : "")) < 0) {
> tst_resm(TWARN|TERRNO, "sprintf() failed");
> }
>
> sounds more suitable?
> If yes you can directly apply it. Let me know if it needs me to resend it.
That one seems to be fine.
--
Cyril Hrubis
[email protected]
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
