On Fri, Mar 16, 2012 at 03:27:44PM +0800, Caspar Zhang wrote: > Hi all, I'll merge this change to master if I don't hear any objections > from you by today.
Fine for me. Copying Gong Chen who did most of the mce-test work recently too. -Andi > > > On 03/09/2012 08:25 AM, Wanlong Gao wrote: > > On 03/09/2012 12:50 AM, Caspar Zhang wrote: > > > >> Hi Garrett, Andi, and all: > >> > >> When I looked into current LTP tree, I found it a little messy due to > >> some mce-test stuff, such as > >> > >> - mce-test docs goes to $TOPDIR/README, and > >> - some mce-test files still lying under testcase/mce-test/. > >> > >> I think we need a cleanup for it. > > > > > > yes, I think so. > > > >> > >> Also an idea comes to my mind, that we can try to make mce-test a > >> submodule of LTP. > > > > > > Not a bad idea. > > > >> > >> I am also thinking about the pros and cons: > >> > >> pro(s): > >> - easier for code maintenance, no need to sync periodically from > >> maintainer side > >> > >> con(s): > >> - two extra steps added for LTP users, they have to do: > >> $ git submodule init > >> $ git submodule update > >> to enable using mce-test. > >> > >> mce-test could no longer be found at kernel.org, so I cloned it from > >> Andi's github repo, not sure if it is the right place: > >> > >> git://github.com/andikleen/mce-test.git > > > > > > The tree seems just a few update every month now, I wonder why intel guys > > didn't sync the commits to LTP ? > > > >> > >> I have made this change to my personal LTP fork, you can review it here: > >> > >> https://github.com/casparant/ltp/commit/5cca17f633 > > > > > > The patch loooks good. > > Wanlong, thanks for review. > > Thanks, > Caspar > > > ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
